-
Notifications
You must be signed in to change notification settings - Fork 312
Add downstream HTTP request/response analysis for OkHttp2 client #9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 51 metrics, 3 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006146
Total [baseline] (10.654 s) : 0, 10654225
Agent [candidate] (1.009 s) : 0, 1009224
Total [candidate] (10.683 s) : 0, 10683045
section appsec
Agent [baseline] (1.184 s) : 0, 1184025
Total [baseline] (10.914 s) : 0, 10914278
Agent [candidate] (1.192 s) : 0, 1191531
Total [candidate] (11.023 s) : 0, 11023450
section iast
Agent [baseline] (1.153 s) : 0, 1153309
Total [baseline] (10.894 s) : 0, 10893919
Agent [candidate] (1.147 s) : 0, 1147094
Total [candidate] (10.936 s) : 0, 10935965
section profiling
Agent [baseline] (1.154 s) : 0, 1154299
Total [baseline] (11.016 s) : 0, 11016104
Agent [candidate] (1.158 s) : 0, 1158271
Total [candidate] (10.999 s) : 0, 10999204
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (688.682 ms) : 0, 688682
BytebuddyAgent [candidate] (689.135 ms) : 0, 689135
GlobalTracer [baseline] (247.597 ms) : 0, 247597
GlobalTracer [candidate] (248.122 ms) : 0, 248122
AppSec [baseline] (31.235 ms) : 0, 31235
AppSec [candidate] (33.173 ms) : 0, 33173
Debugger [baseline] (6.332 ms) : 0, 6332
Debugger [candidate] (6.391 ms) : 0, 6391
Remote Config [baseline] (684.595 µs) : 0, 685
Remote Config [candidate] (716.618 µs) : 0, 717
Telemetry [baseline] (8.974 ms) : 0, 8974
Telemetry [candidate] (9.019 ms) : 0, 9019
section appsec
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (711.0 ms) : 0, 711000
BytebuddyAgent [candidate] (713.86 ms) : 0, 713860
GlobalTracer [baseline] (239.466 ms) : 0, 239466
GlobalTracer [candidate] (240.54 ms) : 0, 240540
AppSec [baseline] (170.577 ms) : 0, 170577
AppSec [candidate] (173.801 ms) : 0, 173801
Debugger [baseline] (6.011 ms) : 0, 6011
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (627.333 µs) : 0, 627
Remote Config [candidate] (630.863 µs) : 0, 631
Telemetry [baseline] (9.112 ms) : 0, 9112
Telemetry [candidate] (9.198 ms) : 0, 9198
IAST [baseline] (24.688 ms) : 0, 24688
IAST [candidate] (24.889 ms) : 0, 24889
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (815.892 ms) : 0, 815892
BytebuddyAgent [candidate] (809.476 ms) : 0, 809476
GlobalTracer [baseline] (239.141 ms) : 0, 239141
GlobalTracer [candidate] (238.203 ms) : 0, 238203
AppSec [baseline] (33.937 ms) : 0, 33937
AppSec [candidate] (35.436 ms) : 0, 35436
Debugger [baseline] (6.167 ms) : 0, 6167
Debugger [candidate] (6.077 ms) : 0, 6077
Remote Config [baseline] (598.783 µs) : 0, 599
Remote Config [candidate] (599.52 µs) : 0, 600
Telemetry [baseline] (8.384 ms) : 0, 8384
Telemetry [candidate] (8.265 ms) : 0, 8265
IAST [baseline] (26.357 ms) : 0, 26357
IAST [candidate] (26.255 ms) : 0, 26255
section profiling
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (720.542 ms) : 0, 720542
BytebuddyAgent [candidate] (719.781 ms) : 0, 719781
GlobalTracer [baseline] (224.605 ms) : 0, 224605
GlobalTracer [candidate] (223.898 ms) : 0, 223898
AppSec [baseline] (31.614 ms) : 0, 31614
AppSec [candidate] (33.23 ms) : 0, 33230
Debugger [baseline] (6.518 ms) : 0, 6518
Debugger [candidate] (6.551 ms) : 0, 6551
Remote Config [baseline] (702.798 µs) : 0, 703
Remote Config [candidate] (780.595 µs) : 0, 781
Telemetry [baseline] (16.255 ms) : 0, 16255
Telemetry [candidate] (15.514 ms) : 0, 15514
ProfilingAgent [baseline] (101.434 ms) : 0, 101434
ProfilingAgent [candidate] (103.298 ms) : 0, 103298
Profiling [baseline] (102.026 ms) : 0, 102026
Profiling [candidate] (105.846 ms) : 0, 105846
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.01 s) : 0, 1009533
Total [baseline] (8.641 s) : 0, 8640670
Agent [candidate] (1.008 s) : 0, 1008215
Total [candidate] (8.661 s) : 0, 8660664
section iast
Agent [baseline] (1.144 s) : 0, 1144152
Total [baseline] (9.336 s) : 0, 9335676
Agent [candidate] (1.157 s) : 0, 1156777
Total [candidate] (9.308 s) : 0, 9308254
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (692.638 ms) : 0, 692638
BytebuddyAgent [candidate] (687.948 ms) : 0, 687948
GlobalTracer [baseline] (247.263 ms) : 0, 247263
GlobalTracer [candidate] (248.426 ms) : 0, 248426
AppSec [baseline] (30.923 ms) : 0, 30923
AppSec [candidate] (33.081 ms) : 0, 33081
Debugger [baseline] (6.325 ms) : 0, 6325
Debugger [candidate] (6.401 ms) : 0, 6401
Remote Config [baseline] (693.633 µs) : 0, 694
Remote Config [candidate] (716.002 µs) : 0, 716
Telemetry [baseline] (9.012 ms) : 0, 9012
Telemetry [candidate] (9.031 ms) : 0, 9031
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (809.435 ms) : 0, 809435
BytebuddyAgent [candidate] (816.413 ms) : 0, 816413
GlobalTracer [baseline] (237.413 ms) : 0, 237413
GlobalTracer [candidate] (239.702 ms) : 0, 239702
AppSec [baseline] (33.547 ms) : 0, 33547
AppSec [candidate] (35.808 ms) : 0, 35808
Debugger [baseline] (6.071 ms) : 0, 6071
Debugger [candidate] (6.17 ms) : 0, 6170
Remote Config [baseline] (589.372 µs) : 0, 589
Remote Config [candidate] (608.314 µs) : 0, 608
Telemetry [baseline] (8.32 ms) : 0, 8320
Telemetry [candidate] (8.521 ms) : 0, 8521
IAST [baseline] (26.107 ms) : 0, 26107
IAST [candidate] (26.674 ms) : 0, 26674
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section baseline
no_agent (37.19 ms) : 36891, 37488
. : milestone, 37190,
appsec (49.127 ms) : 48699, 49554
. : milestone, 49127,
code_origins (45.008 ms) : 44618, 45398
. : milestone, 45008,
iast (44.383 ms) : 44010, 44755
. : milestone, 44383,
profiling (46.624 ms) : 46216, 47032
. : milestone, 46624,
tracing (43.038 ms) : 42674, 43402
. : milestone, 43038,
section candidate
no_agent (37.014 ms) : 36711, 37317
. : milestone, 37014,
appsec (49.671 ms) : 49240, 50102
. : milestone, 49671,
code_origins (43.302 ms) : 42923, 43681
. : milestone, 43302,
iast (44.108 ms) : 43727, 44489
. : milestone, 44108,
profiling (50.346 ms) : 49835, 50858
. : milestone, 50346,
tracing (43.892 ms) : 43523, 44261
. : milestone, 43892,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section baseline
no_agent (4.422 ms) : 4372, 4472
. : milestone, 4422,
iast (9.807 ms) : 9646, 9969
. : milestone, 9807,
iast_FULL (13.943 ms) : 13669, 14217
. : milestone, 13943,
iast_GLOBAL (10.804 ms) : 10606, 11002
. : milestone, 10804,
profiling (9.438 ms) : 9285, 9591
. : milestone, 9438,
tracing (7.927 ms) : 7815, 8039
. : milestone, 7927,
section candidate
no_agent (4.56 ms) : 4508, 4612
. : milestone, 4560,
iast (10.39 ms) : 10215, 10565
. : milestone, 10390,
iast_FULL (14.376 ms) : 14094, 14657
. : milestone, 14376,
iast_GLOBAL (10.674 ms) : 10485, 10864
. : milestone, 10674,
profiling (9.184 ms) : 9029, 9340
. : milestone, 9184,
tracing (7.813 ms) : 7699, 7927
. : milestone, 7813,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section baseline
no_agent (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
appsec (15.125 s) : 15125000, 15125000
. : milestone, 15125000,
iast (18.516 s) : 18516000, 18516000
. : milestone, 18516000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
profiling (15.473 s) : 15473000, 15473000
. : milestone, 15473000,
tracing (15.153 s) : 15153000, 15153000
. : milestone, 15153000,
section candidate
no_agent (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
appsec (15.14 s) : 15140000, 15140000
. : milestone, 15140000,
iast (18.634 s) : 18634000, 18634000
. : milestone, 18634000,
iast_GLOBAL (18.131 s) : 18131000, 18131000
. : milestone, 18131000,
profiling (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
tracing (15.213 s) : 15213000, 15213000
. : milestone, 15213000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~f331f45fc6, baseline=1.54.0-SNAPSHOT~0094a60a80
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.629 ms) : 3415, 3842
. : milestone, 3629,
iast (2.19 ms) : 2128, 2253
. : milestone, 2190,
iast_GLOBAL (2.238 ms) : 2174, 2301
. : milestone, 2238,
profiling (2.063 ms) : 2011, 2116
. : milestone, 2063,
tracing (2.028 ms) : 1978, 2077
. : milestone, 2028,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.707 ms) : 3490, 3924
. : milestone, 3707,
iast (2.187 ms) : 2125, 2249
. : milestone, 2187,
iast_GLOBAL (2.238 ms) : 2174, 2301
. : milestone, 2238,
profiling (2.047 ms) : 1996, 2098
. : milestone, 2047,
tracing (2.029 ms) : 1980, 2078
. : milestone, 2029,
|
e10c32e
to
094375b
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
fe39167
to
1dae6dc
Compare
86ba6d2
to
4ce366c
Compare
🎯 Code Coverage 🔗 Commit SHA: f331f45 | Docs | Was this helpful? Give us feedback! |
4ce366c
to
f331f45
Compare
What Does This Do
Adds support for downstream HTTP request and response analysis in the OkHttp2 client instrumentation.
Motivation
Enable AppSec to analyze outbound requests made through OkHttp2. This expands coverage for API security and SSRF protections, while supporting downstream traffic inspection with configurable sampling.
Additional Notes
RFC
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-58613